test(backend): don't force multipart CONTENT_TYPE in statement import#388
Closed
test(backend): don't force multipart CONTENT_TYPE in statement import#388
Conversation
Owner
Author
|
Fix failing PHPUnit on CI: authenticated test client defaults to CONTENT_TYPE=application/json; override to multipart/form-data for the import upload request (BrowserKit still builds multipart body/boundary). |
|
Backend total line coverage: 56.8% |
algirdasc
deleted the
test/backend-statement-import-uploadedfile-multipart
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the statement import controller functional test to behave like a real multipart upload:
CONTENT_TYPE(BrowserKit needs to generate a boundary)UploadedFileastest: trueAccept: application/json)Why
When
CONTENT_TYPEis forced tomultipart/form-datawithout a boundary, Symfony can't parse the request and the controller sees an empty body. This shows up as a400 Bad Request("Request body is empty.") in CI.How to test
Run backend PHPUnit suite (CI does this). The affected test is:
App\\Tests\\Application\\Controller\\Finance\\StatementImportControllerTest::testSuggest