Skip to content

Potential fix for code scanning alert no. 97: Workflow does not contain permissions #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pangjiping wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 97: Workflow does not contain permissions #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/egress-test.yaml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
paths:
- 'components/egress/**'

permissions:
Copy link
Copy Markdown
Collaborator

@hittyt hittyt Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Redundant and outdated fix

This permissions block has already been added to the main branch (see PR #278). Furthermore, this PR is based on an older version of the workflow and is missing critical recent changes:

  1. The components/internal/** path filter.
  2. Upgraded GitHub Actions versions (e.g., actions/checkout@v6).

Merging this PR would result in a regression of the workflow configuration. It is recommended to close this PR.

contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
Expand Down