Update NPM token secret in release workflow#190
Merged
Conversation
Feels like we should be using the GH Global secret thats 3 months old vs the 5yr old one specific to this repo?
AdamJHall
approved these changes
Mar 5, 2026
|
This should work as is, but we may need to add an npm upgrade step like Will did here: https://github.com/aligent/cdk-constructs/pull/1600/changes and switch out to auth this repo as a "trusted publisher" REF: https://docs.npmjs.com/trusted-publishers |
Contributor
Author
Strangely this part is missing 🤔
Update: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Feels like we should be using the GH Global secret thats 3 months old vs the 5yr old one specific to this repo?
Screenshots (if applicable)

Notes to PR author
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback