Skip to content

Update NPM token secret in release workflow#190

Merged
hubertott merged 1 commit intomainfrom
fix/update-npm-token-reference
Mar 5, 2026
Merged

Update NPM token secret in release workflow#190
hubertott merged 1 commit intomainfrom
fix/update-npm-token-reference

Conversation

@hubertott
Copy link
Contributor

Description of the proposed changes
Feels like we should be using the GH Global secret thats 3 months old vs the 5yr old one specific to this repo?

Screenshots (if applicable)
Screenshot 2026-03-05 at 1 25 51 pm

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned in our contribution guide.

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Feels like we should be using the GH Global secret thats 3 months old vs the 5yr old one specific to this repo?
@hubertott hubertott requested a review from a team as a code owner March 5, 2026 02:56
@hubertott hubertott requested review from AdamJHall and crispy101 March 5, 2026 02:56
@AdamJHall
Copy link

This should work as is, but we may need to add an npm upgrade step like Will did here: https://github.com/aligent/cdk-constructs/pull/1600/changes and switch out to auth this repo as a "trusted publisher" REF: https://docs.npmjs.com/trusted-publishers

@hubertott
Copy link
Contributor Author

hubertott commented Mar 5, 2026

This should work as is, but we may need to add an npm upgrade step like Will did here: https://github.com/aligent/cdk-constructs/pull/1600/changes and switch out to auth this repo as a "trusted publisher" REF: https://docs.npmjs.com/trusted-publishers

Strangely this part is missing 🤔

The critical requirement is the id-token: write permission, which allows GitHub Actions to generate OIDC tokens. Learn more in GitHub's OIDC documentation.

Update:
🤦🏽 Ignore me.. it was already there 😬

@hubertott hubertott merged commit 6d7474e into main Mar 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants