fix(app/provider): use collections-aware iterator in prepForZeroHeightGenesis#43
Merged
Merged
Conversation
Replace the raw store iteration with StakingKeeper.IterateValidators and resolve operator addresses through ValidatorAddressCodec. Also drop the now-unused storetypes import.
giunatale
requested review from
clockworkgr,
giuliostramondo,
julienrbrt and
tbruyelle
as code owners
julienrbrt
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
KVStoreReversePrefixIteratorpattern no longer works in SDK v0.50: validators are now stored viacollections, and decodingiter.Key()[1:]as aValAddressproduces a key thatGetValidatorcannot resolve, causing everyprovider export --for-zero-heightto panic withexpected validator, not found. This blocks all state-export upgrades on the provider.Replace the raw store iteration with
StakingKeeper.IterateValidatorsand resolve operator addresses throughValidatorAddressCodecDiscovered while writing the e2e chain-restart test in PR #44
Merging this PR is required for the e2e test on that PR to pass.