Skip to content

Fix linting error#4051

Merged
andysellick merged 1 commit into
mainfrom
fix-lint-error
May 13, 2026
Merged

Fix linting error#4051
andysellick merged 1 commit into
mainfrom
fix-lint-error

Conversation

@andysellick
Copy link
Copy Markdown
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

What

Fix a syntax error in an erb file.

Why

Multiple PRs are currently failing in govuk_publishing_components because the pre merge checks include linting of the gem itself plus any dependencies, including publishing-api. There are multiple linting errors in that file but I think they stem from this initial typo.

Causing problems like this: https://github.com/alphagov/govuk_publishing_components/actions/runs/25788234714/job/75746836541?pr=5456

@andysellick andysellick requested review from AshGDS and KludgeKML May 13, 2026 09:25
@andysellick andysellick merged commit 4e65ff6 into main May 13, 2026
20 checks passed
@andysellick andysellick deleted the fix-lint-error branch May 13, 2026 09:46
Copy link
Copy Markdown
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants