Fix select_top_level_html_files ignoring custom http_prefix#438
Open
inulty-dfe wants to merge 1 commit intoalphagov:mainfrom
Open
Fix select_top_level_html_files ignoring custom http_prefix#438inulty-dfe wants to merge 1 commit intoalphagov:mainfrom
select_top_level_html_files ignoring custom http_prefix#438inulty-dfe wants to merge 1 commit intoalphagov:mainfrom
Conversation
The parent URL check was hardcoded to "/" so top-level pages were filtered out when http_prefix was set to a custom path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s changed
When we configure a custom
http_prefix(e.g. /docs) to serve our tech docs site under a subpath, Middleman sets the parent URL of top-level pages to/docs/rather than/.select_top_level_html_fileshad the parent URL check hardcoded to "/", so it filtered out all our top-level pages — meaning the multi-page table of contents came back empty.render_page_tree(in the same file) already handled this correctly by computinghome_urlfromconfig[:http_prefix].select_top_level_html_filesjust wasn't updated to match.Here is where we've had to monkey patch the library
Identifying a user need