Cleanups for the tstamp64 merge + make external plugin interface more robust #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link: alsa-project#30 Fixes: 72dd4bb ("compress_hw_get_hpointer: use SNDRV_COMPRESS_AVAIL64") Signed-off-by: Jaroslav Kysela <perex@perex.cz>
We need more validation of passed ops structure to allow further API changes in future. This change looks for compress_plugin_mops symbol in the dynamic plugin library to make sure that the new magic and new get_tstamp64 members are handled correctly. Link: alsa-project#29 Link: alsa-project#30 Fixes: 0bd5530 ("compress_ops: add get_tstamp64") Signed-off-by: Jaroslav Kysela <perex@perex.cz>
It is not required to polute ops with two versions of similar callbacks when we introduced V2 ops. Handle the wrapping in the top level (compress_get_tstamp function). Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Allow to pass unwrapped avail value to applications. Introduce new compress_get_hpointer64() function and change callback in ops. Use UINT_MAX limiting rather than blind wrap like in the previous code in compress_get_hpointer(). Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #29 and #30. Comments are welcome.