update deployment docs for minio bucket creation

[sallyom]

updating deployment to include minio bucket creation

[github-actions]

Claude Code Review

Summary

This PR improves the MinIO deployment documentation and automation by adding automatic bucket creation during deployment, updating documentation to reflect the automated setup process, and providing clear pre-deployment instructions for MinIO credentials. The changes are documentation-focused with minimal code changes to the deploy.sh script.

Issues by Severity

Blocker Issues

None - the PR is safe to merge.

Critical Issues

None identified.

Major Issues

1. Path assumption in deploy.sh may fail in some execution contexts

• Line 379 uses relative path ../../scripts/setup-minio.sh
• Issue: If run from different directory, path check may fail
• Impact: Users see warnings and must run setup-minio manually
• Recommendation: Use absolute path resolution based on script location

2. Documentation inconsistency in file path navigation

• README.md lines 132-136: cd ../.. leaves users in components/manifests/, not repo root
• make deploy expects to run from repo root
• Recommendation: Add cd ../ or clarify directory assumption

Minor Issues

1. Error handling ambiguity - Lines 381-385 suggest errors might be benign, creating uncertainty

2. Documentation style - minio-quickstart.md line 36 uses emoji, inconsistent with CLAUDE.md guidance

3. Missing error diagnostics - Troubleshooting section could document specific error messages

Positive Highlights

✅ Excellent UX improvement - Eliminates manual bucket creation pain point
✅ Idempotent design - Safe to run multiple times
✅ Good error messaging - Provides actionable next steps
✅ Documentation thoroughness - Covers access methods and troubleshooting
✅ Follows doc standards - Updates existing docs vs creating new files
✅ Clear prerequisites - Explicitly calls out MinIO credentials

Recommendations

Priority 1 (Before Merge)

1. Fix path resolution in deploy.sh line 379
2. Fix directory navigation in README.md lines 132-136

Priority 2 (Nice to Have)

1. Improve error detection
2. Remove emoji for consistency
3. Add error messages to troubleshooting

Priority 3 (Future)

1. Add CI test for bucket creation
2. Add verification step in deploy.sh

Security Review

✅ No security issues
✅ Credentials handling appropriate
✅ No auth/authz changes

Code Quality

✅ Follows shell scripting best practices
✅ Consistent with existing patterns
✅ Proper documentation structure

---

Overall: Significantly improves deployment experience. Issues are minor.

Recommended Action: Fix Priority 1 issues, then merge. Priority 2/3 can be follow-ups.

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.