Make aie mailbox message send, platform independent for aie2, aie4 by donwalkarsoham · Pull Request #1103 · amd/xdna-driver

donwalkarsoham · 2026-02-21T02:16:24Z

Problem solved by the commit
Add common mailbox message send method for both aie2 and aie4

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A

How problem was solved, alternative solutions (if any) and why they were rejected
1> Added common logging and mail box message send API for aie2 and aie4
2> Made necessary changes in AIE2. In subsequent PRs AIE4 related changes will be added.

Risks (if any) associated the changes in the commit
N/A

What has been tested and how, request additional testing if necessary
1> Driver installation successful.
2> ./xrt_test 0 1 2 4 7 8 9 ran successfully on Medusa board for below FW version: 0.0.16.125

Documentation impact (if any)
N/A

AMDGithubSCIMAdmin · 2026-02-21T02:17:03Z

Can one of the admins verify this patch?

xdavidz · 2026-02-21T04:33:21Z

-	}
-
-	return ret;
+	drm_WARN_ON(&ndev->xdna->ddev, !mutex_is_locked(&ndev->aie2_lock));


adding the lock here is the right approach I think.

I'd you also add a function for aie4_message.c so people can have a whole picture what code is made common.

Yeah, I was thinking of adding it in the upcoming PRs using other patches. Have mentioned the same in this PR description. But can add it here too.

@xdavidz added the changes in aie4_message.c to use common send message APIs. As discussed offline, removed the AMDXDNA_DEVEL specific timeouts used for simnow specific debugging for aie4 as we are moving towards common aie2 and aie4 code and the common timeouts are enough for silicon.

xdavidz · 2026-02-24T21:43:13Z

+#include "aie_message.h"
+
+int aie_send_msg_wait(struct amdxdna_dev *xdna,
+		      struct mailbox_channel **chann,


I got additional comments from lizhi, please wait for me update my patcheset, then you should syncup with my patcheset.

hlaccabu · 2026-02-26T18:03:31Z

Should common files be aie_message.* or amdxdna_message.? Most common code is amdxdna_ already, no?

xdavidz · 2026-02-26T18:34:02Z

Should common files be aie_message.* or amdxdna_message._? Most common code is amdxdna__ already, no?

Lizhi keeps commenting on the upstream patches. Soham's work is to sync-up with the code that I provided.

The file name is pretty much decided.

xdavidz · 2026-02-27T19:26:48Z

-
-	return ret;
+	drm_WARN_ON(&ndev->xdna->ddev, !mutex_is_locked(&ndev->aie2_lock));
+	return aie_send_msg_wait(ndev->xdna, &ndev->mgmt_chann, msg);


@donwalkarsoham this is not in sync with latest upstream match set.

xdavidz · 2026-02-27T19:27:17Z

+#define DECLARE_AIE_MSG(name, op) DECLARE_XDNA_MSG_COMMON(name, op, -1)
+
+int aie_send_msg_wait(struct amdxdna_dev *xdna,
+		      struct mailbox_channel **chann,


The **chann has been changed. Please re-sync your PR.

NishadSaraf · 2026-03-03T19:00:01Z

retest this please

xdavidz · 2026-03-06T18:18:11Z

 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (C) 2022-2025, Advanced Micro Devices, Inc.
+ * Copyright (C) 2022-2026, Advanced Micro Devices, Inc.


remove this change, no change in this file

xdavidz · 2026-03-06T18:20:32Z

@@ -1,44 +1,17 @@
 /* SPDX-License-Identifier: GPL-2.0 */


delete this file

xdavidz · 2026-03-06T18:21:18Z

do not include aie4_message.h

xdavidz · 2026-03-06T18:22:25Z


 #include <linux/pci.h>

 #include "aie4_pci.h"


#include "amdxdna_pci_drv.h"
#include "aie4_pci.h"
#include "aie4_msg_priv.h"
#include "aie_message.h"

use this include

xdavidz · 2026-03-06T18:23:10Z


 	return (num_vfs == 0) ? aie4_sriov_stop(ndev) : aie4_sriov_start(ndev, num_vfs);
 }
+


remove empty line
checkpatch will not be clean

xdavidz · 2026-03-06T18:24:01Z

 void aie4_put_cert_comp(struct cert_comp *comp);

 #endif /* _AIE4_PCI_H_ */
+


remove empty line

xdavidz · 2026-03-07T00:10:39Z

this needs some additional work.

xdavidz · 2026-03-07T01:44:35Z

@donwalkarsoham can you please squash all commits to one and retest it?

donwalkarsoham · 2026-03-07T23:18:07Z

@donwalkarsoham can you please squash all commits to one and retest it?

Hi @xdavidz, squashed the commits to a single commit.
Hi @NishadSaraf @maxzhen, can you please review and merge this change.

maxzhen · 2026-03-08T04:56:44Z

retest this please

xdavidz · 2026-03-08T20:48:23Z

@donwalkarsoham please fix the conflicts, we cannot merge this due to the conflicts.

donwalkarsoham · 2026-03-08T23:32:26Z

@donwalkarsoham please fix the conflicts, we cannot merge this due to the conflicts.
Waiting for #1157 to be merged. Once done, this PR will rebased and can fix any resultant conflicts.

xdavidz · 2026-03-19T17:14:34Z

we'd obsolete this because we made message.c even common further, will need to sync-up again if necessary, so close this.

donwalkarsoham changed the title ~~Dev1~~ Make aie mailbox message send, platform independent for aie2, aie4 Feb 21, 2026

xdavidz requested review from NishadSaraf and maxzhen February 21, 2026 04:32

xdavidz reviewed Feb 21, 2026

View reviewed changes

xdavidz requested changes Feb 21, 2026

View reviewed changes

xdavidz requested a review from hlaccabu February 23, 2026 01:15

donwalkarsoham requested a review from xdavidz February 24, 2026 01:00

hlaccabu reviewed Feb 24, 2026

View reviewed changes

Comment thread src/driver/amdxdna/aie4_message.h Outdated

xdavidz reviewed Feb 24, 2026

View reviewed changes

xdavidz requested changes Feb 24, 2026

View reviewed changes

hlaccabu previously approved these changes Feb 24, 2026

View reviewed changes

xdavidz reviewed Feb 27, 2026

View reviewed changes

xdavidz requested changes Feb 27, 2026

View reviewed changes

donwalkarsoham dismissed hlaccabu’s stale review via 9ddbe1d March 3, 2026 09:52

donwalkarsoham requested a review from xdavidz March 3, 2026 09:52

xdavidz previously approved these changes Mar 3, 2026

View reviewed changes

xdavidz reviewed Mar 6, 2026

View reviewed changes

donwalkarsoham dismissed xdavidz’s stale review via 8e05703 March 6, 2026 20:25

donwalkarsoham requested a review from xdavidz March 6, 2026 20:32

xdavidz added the do-not-merge label Mar 7, 2026

xdavidz previously approved these changes Mar 7, 2026

View reviewed changes

xdavidz removed the do-not-merge label Mar 7, 2026

donwalkarsoham dismissed xdavidz’s stale review via b7226d7 March 7, 2026 06:20

donwalkarsoham force-pushed the dev1 branch from b7226d7 to b6879ca Compare March 7, 2026 23:16

donwalkarsoham changed the title ~~Make aie mailbox message send, platform independent for aie2, aie4~~ Do not merge: Make aie mailbox message send, platform independent for aie2, aie4 Mar 8, 2026

xdavidz added the do-not-merge label Mar 8, 2026

xdavidz changed the title ~~Do not merge: Make aie mailbox message send, platform independent for aie2, aie4~~ Make aie mailbox message send, platform independent for aie2, aie4 Mar 8, 2026

Make aie mailbox send message common for aie2 and aie4

a892981

donwalkarsoham force-pushed the dev1 branch from b6879ca to a892981 Compare March 10, 2026 23:44

Merge branch 'main' into dev1

16d68a7

xdavidz closed this Mar 19, 2026


		return (num_vfs == 0) ? aie4_sriov_stop(ndev) : aie4_sriov_start(ndev, num_vfs);
		}

		void aie4_put_cert_comp(struct cert_comp *comp);

		#endif /* _AIE4_PCI_H_ */

Conversation

donwalkarsoham commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AMDGithubSCIMAdmin commented Feb 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hlaccabu commented Feb 26, 2026

Uh oh!

xdavidz commented Feb 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NishadSaraf commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xdavidz commented Mar 7, 2026

Uh oh!

xdavidz commented Mar 7, 2026

Uh oh!

donwalkarsoham commented Mar 7, 2026

Uh oh!

maxzhen commented Mar 8, 2026

Uh oh!

xdavidz commented Mar 8, 2026

Uh oh!

donwalkarsoham commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xdavidz commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

donwalkarsoham commented Feb 21, 2026 •

edited

Loading

donwalkarsoham commented Mar 8, 2026 •

edited

Loading