Skip to content

Make AIE PSP code common for aie2 and aie4#1119

Merged
maxzhen merged 1 commit intoamd:mainfrom
donwalkarsoham:dev_patch_3-4
Mar 19, 2026
Merged

Make AIE PSP code common for aie2 and aie4#1119
maxzhen merged 1 commit intoamd:mainfrom
donwalkarsoham:dev_patch_3-4

Conversation

@donwalkarsoham
Copy link
Copy Markdown
Contributor

@donwalkarsoham donwalkarsoham commented Feb 26, 2026 •
edited
Loading

Problem solved by the commit
Add common psp code for both aie2 and aie4

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A

How problem was solved, alternative solutions (if any) and why they were rejected
1> Removed duplicates and merged common code.

Risks (if any) associated the changes in the commit
Should be backward compatible

What has been tested and how, request additional testing if necessary
1> Driver installation successful.
2> Ran xrt_test 0 1 2 3 6 7 9 successfully on Medusa board.

Documentation impact (if any)
N/A

@AMDGithubSCIMAdmin
Copy link
Copy Markdown

AMDGithubSCIMAdmin commented Feb 26, 2026

Can one of the admins verify this patch?

@xdavidz
Copy link
Copy Markdown
Contributor

xdavidz commented Feb 26, 2026

ok to test

hlaccabu
hlaccabu previously approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hlaccabu hlaccabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xdavidz
xdavidz reviewed Feb 27, 2026
View reviewed changes
Comment thread src/driver/amdxdna/aie2_message.c Outdated
xdavidz
xdavidz reviewed Feb 27, 2026
View reviewed changes
Comment thread src/driver/amdxdna/aie2_pci.c Outdated
@donwalkarsoham donwalkarsoham requested a review from xdavidz March 3, 2026 04:06
xdavidz
xdavidz reviewed Mar 3, 2026
View reviewed changes
Comment thread src/driver/amdxdna/aie_psp.c Outdated
@NishadSaraf
Copy link
Copy Markdown
Member

NishadSaraf commented Mar 3, 2026

retest this please

@donwalkarsoham donwalkarsoham requested a review from xdavidz March 3, 2026 20:26
xdavidz
xdavidz reviewed Mar 3, 2026
View reviewed changes
Comment thread src/driver/amdxdna/aie_psp.c Outdated
xdavidz
xdavidz reviewed Mar 6, 2026
View reviewed changes
Comment thread src/driver/amdxdna/npu3_regs.c
@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 6, 2026

retest this please

@xdavidz
Copy link
Copy Markdown
Contributor

xdavidz commented Mar 6, 2026

This PR needs more work. Stay tuned.

xdavidz
xdavidz previously approved these changes Mar 7, 2026
View reviewed changes
@xdavidz
Copy link
Copy Markdown
Contributor

xdavidz commented Mar 7, 2026

it is ok as long as it passes pipeline. I will clean this up later.

@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 8, 2026

retest this please

@xdavidz
Copy link
Copy Markdown
Contributor

xdavidz commented Mar 8, 2026

@donwalkarsoham pleas fix the conflicts. I think Max merged your smu PR, that can have conflicts with your psp code change.

You need to fix the conflicts resent PR to me for review again.

@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 8, 2026

@donwalkarsoham pleas fix the conflicts. I think Max merged your smu PR, that can have conflicts with your psp code change.

You need to fix the conflicts resent PR to me for review again.

Waiting for #1157 to be merged. Once done, this PR will rebased and can fix any resultant conflicts.

@donwalkarsoham donwalkarsoham requested a review from xdavidz March 11, 2026 04:49
@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 11, 2026

retest this please

xdavidz
xdavidz previously approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xdavidz xdavidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

hlaccabu
hlaccabu previously approved these changes Mar 11, 2026
View reviewed changes
@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 12, 2026

retest this please

2 similar comments
@xdavidz
Copy link
Copy Markdown
Contributor

xdavidz commented Mar 13, 2026

retest this please

@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 14, 2026

retest this please

@amd-gevadlam
Copy link
Copy Markdown
Collaborator

amd-gevadlam commented Mar 16, 2026

retest this please

@donwalkarsoham donwalkarsoham dismissed stale reviews from xdavidz and hlaccabu via d9d5948 March 16, 2026 05:37
@donwalkarsoham donwalkarsoham force-pushed the dev_patch_3-4 branch 2 times, most recently from d9d5948 to 979a658 Compare March 16, 2026 06:33
@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 16, 2026

retest this please

maxzhen
maxzhen previously approved these changes Mar 16, 2026
View reviewed changes
@donwalkarsoham
Copy link
Copy Markdown
Contributor Author

donwalkarsoham commented Mar 16, 2026

retest this please

@donwalkarsoham
Make AIE PSP code common for aie2 and aie4
adb722b 
Signed-off-by: Soham Donwalkar <soham.donwalkar@amd.com>
@maxzhen maxzhen merged commit bbfcf4b into amd:main Mar 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxzhen maxzhen maxzhen approved these changes

@xdavidz xdavidz xdavidz approved these changes

@NishadSaraf NishadSaraf Awaiting requested review from NishadSaraf

@hlaccabu hlaccabu Awaiting requested review from hlaccabu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@donwalkarsoham @AMDGithubSCIMAdmin @xdavidz @NishadSaraf @amd-gevadlam @maxzhen @hlaccabu