Modernisation 27 - Switch to mocha bdd style in preparation for moving to node test runner#831
Merged
cressie176 merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
cressie176
commented
Sep 7, 2025
| "noPrototypeBuiltins": "error", | ||
| "noVar": "error" | ||
| "noVar": "error", | ||
| "noExportsInTest": "off" |
Collaborator
Author
There was a problem hiding this comment.
Now that the tests have describe / it, biome recognises them as tests and complains about the exports
cressie176
commented
Sep 7, 2025
| } | ||
| describe('Error handling', () => { | ||
|
|
||
| it('Throw error in connection open callback', (done) => { |
Collaborator
Author
There was a problem hiding this comment.
Since amqplib no longer supports v0.8 or earlier, we no longer have to worry about ignoring the test in earlier version
cressie176
commented
Sep 7, 2025
| .then((open) => { | ||
| send(defs.ChannelCloseOk, {}, open.channel); | ||
| }) | ||
| .then(succeed(done), fail(done))) |
Collaborator
Author
There was a problem hiding this comment.
Fixed the formatting that was somehow missed in the previous PR
cressie176
commented
Sep 7, 2025
| }) | ||
| .then(succeed(done), fail(done)); | ||
| } | ||
| )); |
Collaborator
Author
There was a problem hiding this comment.
Fixed some more formatting that was previously missed in the previous PR
cressie176
commented
Sep 7, 2025
| send(defs.BasicDeliver, DELIVER_FIELDS, ch, Buffer.from('')); | ||
| }, done); | ||
| } | ||
| )); |
Collaborator
Author
There was a problem hiding this comment.
More formatting fixes
cressie176
changed the base branch from
amqplib-modernisation-26-format-tests
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.