Fix compatibility for make_forge and load_boston in sklearn 1.2+ #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
您的邮件已收到，我将会尽快处理，谢谢。王宇凝
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amueller,
I've noticed that load_boston and make_forge have compatibility issues with recent versions of scikit-learn. I have submitted this PR to ensure the notebooks remain functional for students and researchers.
Summary of changes:
Handled the deprecation/removal of load_boston by ensuring it loads correctly from internal sources/fallback.
Verified make_forge dataset generation.
Validation: I have verified these changes using pytest. Both test cases passed (Verified data shapes: 506x13 for Boston and correct labels for Forge).