Build all the vader workers, not just the default one#1172
Open
LourensVeen wants to merge 2 commits intoamusecode:mainfrom
Open
Build all the vader workers, not just the default one#1172LourensVeen wants to merge 2 commits intoamusecode:mainfrom
LourensVeen wants to merge 2 commits intoamusecode:mainfrom
Conversation
Collaborator
|
I just wanted to mention that I've also stumbled upon the problem, and adopting your changes helped me fix it. I think this should be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the vader build system to build all the different problems included with the code. As far as I can tell, the original version didn't do this automatically, it would only build the
noneversion. That still works with these changes, but now you also get all the others. You can select a non-default worker by something likeVader(mode='cmzdisk'), as before.Should fix #1153, I've asked Maite to check that it all works.