fix: correct include guard in TMC2240_HW_Abstraction.h, TMC2240.h, TMC2241_HW_Abstraction.h, TMC2241.h#82
Open
PetryaevAlex wants to merge 1 commit intoanalogdevicesinc:masterfrom
Conversation
…C2241_HW_Abstraction.h, TMC2241.h. Include Guard was duplicating TMC_IC_TMC2240_H_ from TMC2240.h, causing the entire HW_Abstraction header to be skipped by the preprocessor when both files are included. Fixed to use unique TMC2240_HW_ABSTRACTION guard and added define to guard in TMC2240.h. Same situation with 2241 driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
TMC2240_HW_Abstraction.h uses the same include guard (TMC_IC_TMC2240_H_)
as TMC2240.h. And in TMC2240.h no include guard define. When both files are included, the preprocessor skips
HW_Abstraction entirely, causing compilation errors due to missing
register/field definitions.
Same with 2241 driver
Fix: Use unique TMC2240_HW_ABSTRACTION guard and added define to guard in TMC2240.h. Same situation with 2241 driver.
Same with 2241 driver