This repository was archived by the owner on Feb 12, 2021. It is now read-only.
Updating gracefull-fs.#230
Open
petermilan wants to merge 2 commits intoandrewrk:masterfrom
Open
Conversation
|
This needs to be fixed, Please accept this |
|
We need this - please accept this PR. |
|
@andrewrk @kacole2 @faceleg @maki10 @dvalentiate It appears this simple update would significantly reduce problems we're having using the library. We've been on Node 12 for a while. Merging this update would be fantastic. |
|
^ bump this affects my company as well. |
|
Hi, Any update on this? We all urgently need it, as the node 12 is a minimum requirement for our projects. |
|
While @andrewrk is busy creating zig try this if you are using yarn... Add following to your package.json |
gernerBAH
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to run node-s3-client on node v12 we need to update gracefull-fs package.