Skip to content

[deps] upgrade grpc-go to 1.79.3#215

Open
capcom6 wants to merge 1 commit intomasterfrom
deps/upgrade-grpc-go
Open

[deps] upgrade grpc-go to 1.79.3#215
capcom6 wants to merge 1 commit intomasterfrom
deps/upgrade-grpc-go

Conversation

@capcom6
Copy link
Copy Markdown
Member

@capcom6 capcom6 commented Mar 26, 2026

Summary by CodeRabbit

  • Chores

    • Updated Go toolchain and Docker base image; bumped dependencies for security, stability, and telemetry improvements.
    • Upgraded messaging and cloud client libraries to newer stable releases.
  • Refactor

    • Standardized background task/goroutine management for more reliable lifecycle and shutdown behavior.
    • Hardened push/messaging initialization to use improved authentication handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 548eb114-a28e-4367-aa9b-ccb943c9edad

📥 Commits

Reviewing files that changed from the base of the PR and between 68f05c1 and c12f366.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • build/package/Dockerfile
  • go.mod
  • internal/sms-gateway/app.go
  • internal/sms-gateway/modules/messages/service.go
  • internal/sms-gateway/modules/push/fcm/client.go
  • pkg/pubsub/memory.go
✅ Files skipped from review due to trivial changes (4)
  • internal/sms-gateway/modules/messages/service.go
  • internal/sms-gateway/modules/push/fcm/client.go
  • build/package/Dockerfile
  • internal/sms-gateway/app.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/pubsub/memory.go

Walkthrough

Bump Go toolchain (Dockerfile + go.mod) to 1.25; substantial dependency upgrades in go.mod (notably Firebase, gRPC, OpenTelemetry and related libs); small refactors replacing manual WaitGroup add/done with wg.Go(...); Firebase credentials call switched to option.WithAuthCredentialsJSON(...).

Changes

Cohort / File(s) Summary
Build / Go version
build/package/Dockerfile, go.mod
Updated build base image and Go directive to 1.25.0.
Dependencies
go.mod
Bumped direct deps (e.g., firebase.google.com/go/v4, golang.org/x/crypto, google.golang.org/api) and reworked many indirects to newer OpenTelemetry, gRPC, protobuf, and Google Cloud modules.
WaitGroup refactor
internal/sms-gateway/app.go, internal/sms-gateway/modules/messages/service.go, pkg/pubsub/memory.go
Replaced manual wg.Add(1) + go ... defer wg.Done() patterns with wg.Go(func(){ ... }) for background goroutines.
Firebase auth change
internal/sms-gateway/modules/push/fcm/client.go
Switched Firebase app construction from option.WithCredentialsJSON([]byte(creds)) to option.WithAuthCredentialsJSON(option.ServiceAccount, []byte(creds)).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to upgrade grpc-go to 1.79.3, but the changes include upgrading Go from 1.24.3 to 1.25.0, updating multiple dependencies including Firebase, crypto, and Google API libraries, and refactoring goroutine lifecycle management across multiple files. The title is misleading about the primary scope of changes. Update the title to reflect the actual main changes, such as 'Upgrade Go to 1.25.0 and update dependencies' or 'deps: upgrade Go to 1.25.0 and update Google Cloud dependencies'.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

🤖 Pull request artifacts

Platform File
🐳 Docker GitHub Container Registry
🍎 Darwin arm64 server_Darwin_arm64.tar.gz
🍎 Darwin x86_64 server_Darwin_x86_64.tar.gz
🐧 Linux arm64 server_Linux_arm64.tar.gz
🐧 Linux i386 server_Linux_i386.tar.gz
🐧 Linux x86_64 server_Linux_x86_64.tar.gz
🪟 Windows arm64 server_Windows_arm64.zip
🪟 Windows i386 server_Windows_i386.zip
🪟 Windows x86_64 server_Windows_x86_64.zip

@capcom6 capcom6 force-pushed the deps/upgrade-grpc-go branch from b640577 to 68f05c1 Compare March 27, 2026 09:39
@capcom6 capcom6 added the ready label Mar 28, 2026
@capcom6 capcom6 force-pushed the deps/upgrade-grpc-go branch from 68f05c1 to c12f366 Compare March 29, 2026 07:47
@github-actions github-actions bot removed the ready label Mar 29, 2026
@capcom6 capcom6 added the deployed The PR is deployed on staging label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployed The PR is deployed on staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant