Fix ConfigValues.observe to catch provider exceptions

[kirich1409]

Summary

• ConfigValues.observe collected provider Flows raw via merge with no .catch, so any exception thrown downstream by localProvider.observe(param) propagated straight into the consumer's coroutine and crashed the host — violating the documented contract ("flow does not terminate on provider error").
• Fix: wrap both localFlow and remoteFlow in .catch { e -> onProviderError(e) } before passing them to merge. The Flow operator .catch ignores CancellationException by design, so no manual rethrow is needed.
• getValue was already guarded via runCatching; this patch makes observe consistent with it.

Regression test

ProviderErrorObserveTest.observeDoesNotPropagateWhenLocalProviderFlowThrows
(core/src/commonTest/kotlin/dev/androidbroadcast/featured/ProviderErrorObserveTest.kt)

Constructs a fake LocalConfigValueProvider whose observe() emits one value then throws IllegalStateException("simulated provider error"), collects via Turbine, and asserts:

• collection does not throw
• onProviderError receives exactly one IllegalStateException with the expected message
• both the default emission and the local-provider emission were collected

Follow-up PRs enabled

This fix unblocks PRs that register providers with types they don't support (e.g. DataStore enum converters) — the flow will now degrade gracefully rather than crashing.

Test plan

• ./gradlew :core:allTests — green (JVM + iOS simulator)
• ./gradlew spotlessCheck — green
• ./gradlew :core:koverVerify — ≥90% coverage gate passes

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[Copilot]

Pull request overview

Fixes a bug in ConfigValues.observe where exceptions thrown by localProvider.observe(param) propagated to consumers and crashed the host coroutine, contradicting the documented contract that the flow does not terminate on provider error. The fix wraps both upstream flows in .catch so provider errors are routed to the onProviderError callback, matching the existing behavior of getValue.

Changes:

• Apply .catch { e -> onProviderError(e) } to both localFlow and remoteFlow in observe before merging.
• Add a regression test ProviderErrorObserveTest using Turbine to verify that a throwing local provider does not propagate the error and that emissions before the error are still collected.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
core/src/commonMain/kotlin/dev/androidbroadcast/featured/ConfigValues.kt	Wraps the local and remote upstream flows in .catch to forward provider exceptions to onProviderError instead of crashing the consumer.
core/src/commonTest/kotlin/dev/androidbroadcast/featured/ProviderErrorObserveTest.kt	New test verifying observe survives a throwing local provider flow and routes the error to onProviderError.