Fallback to displayAlign from style for TTML regions#3094
Fallback to displayAlign from style for TTML regions#3094FineFindus wants to merge 1 commit intoandroidx:mainfrom
displayAlign from style for TTML regions#3094Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| if (styleId != null) { | ||
| TtmlStyle style = globalStyles.get(styleId); | ||
| if (style != null) { | ||
| displayAlign = style.getDisplayAlign(); |
There was a problem hiding this comment.
I think for consistency with the way we handle other attributes, this 'inheritance' logic should be implemented as part of TtmlStyle.chain which is invoked here:
See my comment here: #2559 (comment)
There was a problem hiding this comment.
Done, should I also add a test for inheriting displayAlign from another style?
There was a problem hiding this comment.
You can probably tweak your existing test file to exercise this?
FineFindus
force-pushed
the
fix/display-align-fallback
branch
from
73b6e9c to
be7890f
Compare
Adds support for using the `displayAlign` from the `style` of a region, if it has no explicit `displayAlign` set. Closes: androidx#2559
FineFindus
force-pushed
the
fix/display-align-fallback
branch
from
be7890f to
7750885
Compare
2 participants
Adds support for using the
displayAlignfrom thestyleof a region, if it has no explicitdisplayAlignset.Closes: #2559