fixup! refactor: remove tree-kill dependency and refactor killAllProcesses to use native childProc.kill with retries.

Author: alan-agius4

tests/e2e/utils/process.ts

@@ -254,7 +254,7 @@ export async function waitForAnyProcessOutputToMatch(
   return matchingProcess;
 }
 
-async function killProcess(pid: number, signal: string): Promise<void> {
+async function killProcess(pid: number, signal: NodeJS.Signals): Promise<void> {
   if (process.platform === 'win32') {
     // /T kills child processes, /F forces it
     await exec(`taskkill /pid ${pid} /T /F`);
@@ -266,23 +266,20 @@ async function killProcess(pid: number, signal: string): Promise<void> {
 /**
  * Kills all tracked processes
  */
-export async function killAllProcesses(signal: NodeJS.Signals = 'SIGTERM'): Promise<void> {
-  let attempts = 0;
-  while (_processes.length > 0) {
-    attempts++;
-
-    // Iterate backwards so we can remove elements while looping if needed.
-    for (let i = _processes.length - 1; i >= 0; i--) {
-      const childProc = _processes[i];
 
-      if (!childProc || childProc.killed || !childProc.pid) {
-        _processes.splice(i, 1);
-        continue;
-      }
+export async function killAllProcesses(signal: NodeJS.Signals = 'SIGTERM'): Promise<void> {
+  const processesToKill: Promise<void>[] = [];
 
-      await killProcess(childProc.pid, signal);
+  while (_processes.length) {
+    const childProc = _processes.pop();
+    if (!childProc || childProc.pid === undefined || childProc.killed) {
+      continue;
     }
+
+    processesToKill.push(killProcess(childProc.pid, signal));
   }
+
+  await Promise.all(processesToKill);
 }
 
 export function exec(cmd: string, ...args: string[]) {