wip

Author: alan-agius4

tests/e2e/utils/process.ts

@@ -1,7 +1,6 @@
 import { spawn, SpawnOptions } from 'node:child_process';
 import * as child_process from 'node:child_process';
 import { getGlobalVariable, getGlobalVariablesEnv } from './env';
-import { setTimeout as sleep } from 'node:timers/promises';
 import { delimiter, join, resolve } from 'node:path';
 import { stripVTControlCharacters, styleText } from 'node:util';
 
@@ -255,35 +254,33 @@ export async function waitForAnyProcessOutputToMatch(
   return matchingProcess;
 }
 
+async function killProcess(pid: number, signal: string): Promise<void> {
+  if (process.platform === 'win32') {
+    // /T kills child processes, /F forces it
+    await exec(`taskkill /pid ${pid} /T /F`);
+  } else {
+    process.kill(-pid, signal);
+  }
+}
+
 /**
- * Kills all tracked processes with a retry mechanism.
+ * Kills all tracked processes
  */
 export async function killAllProcesses(signal: NodeJS.Signals = 'SIGTERM'): Promise<void> {
   let attempts = 0;
-  const maxRetries = 3;
-
-  while (_processes.length > 0 && attempts < maxRetries) {
+  while (_processes.length > 0) {
     attempts++;
 
     // Iterate backwards so we can remove elements while looping if needed.
     for (let i = _processes.length - 1; i >= 0; i--) {
       const childProc = _processes[i];
 
-      if (!childProc || childProc.killed) {
+      if (!childProc || childProc.killed || !childProc.pid) {
         _processes.splice(i, 1);
         continue;
       }
 
-      const killed = childProc.kill(signal);
-      if (killed) {
-        _processes.splice(i, 1);
-        continue;
-      }
-    }
-
-    // If still have processes, wait a bit before the next retry (e.g., 100ms)
-    if (_processes.length > 0 && attempts < maxRetries) {
-      await sleep(100);
+      await killProcess(childProc.pid, signal);
     }
   }
 }