refactor: improve findUp utility correctness and performance#32275
Merged
clydin merged 1 commit intoangular:mainfrom Jan 13, 2026
Merged
refactor: improve findUp utility correctness and performance#32275clydin merged 1 commit intoangular:mainfrom
findUp utility correctness and performance#32275clydin merged 1 commit intoangular:mainfrom
Conversation
This change modernizes the `findUp` utility across the codebase. Replaced `path.parse().root` with `path.dirname(dir) === dir` check. Introduced an asynchronous version (`findUp`) in the CLI utility and renamed the synchronous version to `findUpSync` to align with Node.js conventions. Updated `packages/angular/cli/src/utilities/config.ts` to use the asynchronous `findUp` for non-blocking configuration discovery.
hybrist
approved these changes
Jan 12, 2026
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modernizes the
findUputility across the codebase. Replacedpath.parse().rootwithpath.dirname(dir) === dircheck. Introduced an asynchronous version (findUp) in the CLI utility and renamed the synchronous version tofindUpSyncto align with Node.js conventions. Updatedpackages/angular/cli/src/utilities/config.tsto use the asynchronousfindUpfor non-blocking configuration discovery.