refactor: remove deprecated compiler option#32330
refactor: remove deprecated compiler option#32330crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
force-pushed
the
ts-6-base-url
branch
from
75d1ecd to
7d8ff76
Compare
Removes usages of the `baseUrl` compiler option which is deprecated and will start throwing an error in TypeScript 6.
crisbeto
force-pushed
the
ts-6-base-url
branch
from
7d8ff76 to
b578c52
Compare
| }); | ||
|
|
||
| // TODO(crisbeto): the `baseUrl` here will trigger a deprecation error in TS6. We may | ||
| // have to opt out of it for this test since Webpack seems to depend on the `baseUrl`. |
There was a problem hiding this comment.
The context here is that it should work without the baseUrl since the default has been ./ for a while, but it doesn't for some reason. I suspect something in Webpack might be depending on it. Once TS6 is out, we can opt out these tests from the deprecation error.
crisbeto
added
action: review
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
In general, this LGTM, though one of the test cases updates is incorrect.
| @@ -67,10 +67,10 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => { | |||
|
|
|||
| it(`should collect coverage from paths in 'sourceRoot'`, async () => { | |||
There was a problem hiding this comment.
This changes the test. Coverage from node_modules is always ignored.
In this case, we want to ensure that coverage for local libraries is not included (IE: not included in node_module).
alan-agius4
added
action: cleanup
|
I'll close this one for now and will deal with it when bumping to TS6. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Removes usages of the
baseUrlcompiler option which is deprecated and will start throwing an error in TypeScript 6.