Skip to content

build: update dependency https-proxy-agent to v8 (main) #32762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angular-robot wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Open

build: update dependency https-proxy-agent to v8 (main) #32762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"beasties": "0.4.1",
"browserslist": "^4.26.0",
"esbuild": "0.27.3",
"https-proxy-agent": "7.0.6",
"https-proxy-agent": "8.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The update to https-proxy-agent@8.0.0 is a major change that migrates the package to be ESM-only. This will break the current static import usage in packages/angular/build/src/utils/index-file/inline-fonts.ts, as this project appears to be CommonJS. This will likely cause a runtime error when trying to use a proxy for inlining fonts.

To resolve this, the static import should be converted to a dynamic import() within the getResponse method where it is used.

Here are the suggested changes for packages/angular/build/src/utils/index-file/inline-fonts.ts:

  1. Remove the static import at the top of the file:

    // import { HttpsProxyAgent } from 'https-proxy-agent';

  2. Update the getResponse method to dynamically import and instantiate HttpsProxyAgent:

    private async getResponse(url: URL): Promise<string> {
  // ...
  const httpsProxy = process.env.HTTPS_PROXY ?? process.env.https_proxy;
  const agent = httpsProxy
    ? new (await import('https-proxy-agent')).HttpsProxyAgent(httpsProxy)
    : undefined;

  const data = await new Promise<string>((resolve, reject) => {
    let rawResponse = '';
    httpsGet(
      url,
      {
        agent,
        headers: {
        // ...

"istanbul-lib-instrument": "6.0.3",
"jsonc-parser": "3.3.1",
"listr2": "10.2.1",
Expand Down
21 changes: 19 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading