fix(ng-dev): only log failures to when on actual failing exit codes when on-error mode is set
#3307
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
force-pushed
the
logging-fixups
branch
from
3d6d5ac to
0770fc6
Compare
alan-agius4
approved these changes
Dec 16, 2025
…hen `on-error` mode is set Previously `on-error` would always log because we didn't check to confirm the exit code as actually indicating an error (i.e. != 0)
josephperrott
force-pushed
the
logging-fixups
branch
from
0770fc6 to
2378199
Compare
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
on-errorwould always log because we didn't check to confirm the exit code as actually indicating an error (i.e. != 0)