Conversation
warning: use of deprecated item 'try': use the `?` operator instead warning: trait objects without an explicit `dyn` are deprecated warning: variant `MRB_TT_FALSE` should have an upper camel case name warning: `#[inline]` is ignored on function prototypes warning: the type `bool` does not permit being left uninitialized warning: use of deprecated item 'core::str::<impl str>::trim_right_matches': superseded by `trim_end_matches` warning: variable does not need to be mutable warning: unused return value of `std::clone::Clone::clone` that must be used
- C side `[const] char*` is Rust side `*const c_char` or `*const c_uchar` - C side `void*` is Rust side `*const u8`
How to fix: mrb_load_nstring_cxt in the callback called by mrb_define_method throws an exception when an Exception occurs, which cannot be caught with panic::catch_unwind. I am changing so that no exception is thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo test