Support for non-UTC time zones in datetime conversion#131
Merged
ankane merged 1 commit intoankane:masterfrom Apr 25, 2026
Merged
Support for non-UTC time zones in datetime conversion#131ankane merged 1 commit intoankane:masterfrom
ankane merged 1 commit intoankane:masterfrom
Conversation
Owner
|
Hi @wtn, thanks for the PR. Looks good overall, but a few comments:
|
Contributor
Author
|
Thank you for feedback. I've updated the commit message trailer, revised |
ankane
reviewed
Apr 25, 2026
Owner
ankane
left a comment
There was a problem hiding this comment.
Thanks, added some comments inline.
c5389ad to
b423c80
Compare
Owner
|
Looks great, thanks! |
ankane
added a commit
that referenced
this pull request
Apr 25, 2026
Owner
|
Made |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
_to_ruby_datetimeraisedTodofor non-UTC zones, anddatetime_to_rb_object.unwrap()'d the funcall, so the Ruby exception became a thread panic.Moves datetime conversion into Rust, mirroring py-polars (
crates/polars-python/src/conversion/datetime.rs):chrono-tzfor named zones,FixedOffsetfor offsets.any_value_into_rb_objectnow returnsRbResult<Value>so tz parse errors raise instead of panic. Ruby-side_to_ruby_datetimeis removed.