Open
Conversation
Owner
|
Hi vossccp, Overall this is good. However the |
Author
|
Yes, you are right. I was a bit confused since Dispose should close the stream. I hope, its ok for you if we just flush before returning the content |
Owner
|
Sorry for late follow-up. The GZipStream Flush method is not implemented to flush underlying buffer as mentioned here. We need to explicitly close the stream. Just call Close on |
Author
|
Hi there. We never really came to finish this. Hope, its now ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ankit,
The RedisStore pretended to be non-Static; I have taken the liberty to make a static implementation of the cache (in fact, it was already static before).
Also, I felt the integration to the bot framework could be simplified by just configuring the Redis Bot cache. I think, by explicitly configuring the bot cache, we can assume that the user wants to use it with the bot framework, so we can do the configuration for him.