test: capture env var prefix permission bypass (#16075)#16086
Open
fazzledev wants to merge 1 commit intoanomalyco:devfrom
Open
test: capture env var prefix permission bypass (#16075)#16086fazzledev wants to merge 1 commit intoanomalyco:devfrom
fazzledev wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #16075
Type of change
What does this PR do?
Adds a test case that captures the env var prefix permission bypass bug. Commands like
CI=true git commitproduce a permission pattern of"CI=true git commit -m \"test\""instead of"git commit -m \"test\"", so a rule like"git *": "ask"won't match and the command runs without a dialog.The test currently asserts the buggy behavior with a TODO to flip the assertions once the fix lands.
How did you verify your code works?
Ran
bun test test/tool/bash.test.ts test/permission/arity.test.ts test/permission/next.test.ts— 84 pass, 0 fail.Screenshots / recordings
N/A — no UI change.
Checklist