Skip to content

fix(lsp): timeout write to prevent hang when LSP server stdin is full #16114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayZenith wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(lsp): timeout write to prevent hang when LSP server stdin is full #16114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/opencode/src/lsp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { LSPServer } from "./server"
import z from "zod"
import { Config } from "../config/config"
import { spawn } from "child_process"
import { withTimeout } from "../util/timeout"
import { Instance } from "../project/instance"
import { Flag } from "@/flag/flag"

Expand Down Expand Up @@ -274,13 +275,18 @@ export namespace LSP {
return false
}

// Prevent indefinite hang when LSP server stdin is full (e.g. pyright under CPU load).
const LSP_WRITE_TIMEOUT_MS = 3_000

export async function touchFile(input: string, waitForDiagnostics?: boolean) {
log.info("touching file", { file: input })
const clients = await getClients(input)
await Promise.all(
clients.map(async (client) => {
const wait = waitForDiagnostics ? client.waitForDiagnostics({ path: input }) : Promise.resolve()
await client.notify.open({ path: input })
await withTimeout(client.notify.open({ path: input }), LSP_WRITE_TIMEOUT_MS).catch((err) => {
log.warn("LSP write timed out, skipping notification", { err, file: input })
})
return wait
}),
).catch((err) => {
Expand Down
Loading