fix(tui): use markdownCodeBlock color for fenced code blocks#16131
Open
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): use markdownCodeBlock color for fenced code blocks#16131zerone0x wants to merge 1 commit intoanomalyco:devfrom
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Conversation
…language Code blocks without a language specifier (``` without language tag) were using theme.markdownCode (inline code color) instead of theme.markdownCodeBlock. On light terminal backgrounds with custom themes, markdownCode is typically a bright accent color (e.g., green, pink) that becomes invisible against light backgrounds. markdownCodeBlock is designed for this purpose and defaults to the foreground text color. Fixes anomalyco#16121 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16121
Type of change
What does this PR do?
Fenced code blocks without a language specifier (e.g.,
```instead of```javascript) were usingtheme.markdownCode(the inline code color) instead oftheme.markdownCodeBlock. On light terminal backgrounds with custom themes,markdownCodeis typically a bright accent color (green, pink, etc.) that becomes invisible or barely visible against light backgrounds.The theme type system already defines a separate
markdownCodeBlockproperty for this exact purpose, and every built-in theme sets it to a readable foreground/text color. However, the syntax highlighting scope rules groupedmarkup.rawandmarkup.raw.blocktogether, applying the inline code color to both.The fix: Split the scope rules so that:
markup.raw.block→ usestheme.markdownCodeBlock(readable text color)markup.raw/markup.raw.inline→ usestheme.markdownCode(accent color, with background)This is a 3-line change in the
getSyntaxRulesfunction intheme.tsx.How did you verify your code works?
markdownCodeBlockproperty exists in theThemeColorstype (line 89) with typeRGBAmarkdownCodeBlockas a readable foreground colormarkdownCodeBlocktofg(foreground)markdownCodeandmarkdownCodeBlockare typed asRGBAChecklist
🤖 Generated with Claude Code