feat(opencode): add macOS to test matrix#16663
Open
brndnblck wants to merge 1 commit intoanomalyco:devfrom
Open
feat(opencode): add macOS to test matrix#16663brndnblck wants to merge 1 commit intoanomalyco:devfrom
brndnblck wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16661
Related: #16647
Type of change
What does this PR do?
Adds a
macos-latestrunner to both theunitande2etest matrices in.github/workflows/test.yml.The test matrix currently only covers Linux and Windows. The symlink regression in #16647 was macOS-specific —
process.cwd()preserves symlink paths on macOS but Linux'sgetcwd()returns the canonical path — and would have been caught by a macOS CI runner.This also improves coverage for case-sensitivity differences (macOS APFS is case-insensitive by default) and other Darwin/Linux POSIX divergences.
Uses
macos-latest, consistent with the runner label already used inpublish.yml.How did you verify your code works?
setup-bunaction already handles macOS (caseon line 21)macos-latestis the same runner label used in other workflows (publish.yml)bunx playwright install(no--with-deps), matching the Windows patternChecklist