fix(ui): preserve SVG tags in DOMPurify config for KaTeX math rendering#25866
Open
zharinov wants to merge 1 commit intoanomalyco:devfrom
Open
fix(ui): preserve SVG tags in DOMPurify config for KaTeX math rendering#25866zharinov wants to merge 1 commit intoanomalyco:devfrom
zharinov wants to merge 1 commit intoanomalyco:devfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue for this PR
Closes #25812
Type of change
What does this PR do?
DOMPurify was stripping
<svg>and<path>elements from KaTeX-rendered HTML. KaTeX renders\sqrt,\overrightarrow,\widehat,\widetilde,\overbrace,\underbraceas inline SVG — these were silently removed during sanitization, leaving the radicand visible but the radical symbol missing.Added
ADD_TAGS: ["svg", "path"]and the necessary SVG attributes (d,viewBox,preserveAspectRatio,xmlns) to the DOMPurify config.How did you verify your code works?
Tested in desktop dev build:
All render correctly. DOMPurify still strips event handlers on SVG elements.
Screenshots / recordings
Checklist