refactor: remove unused DynamicDescription hack in tool.ts#25907
Open
srivenkateswaran6002 wants to merge 2 commits intoanomalyco:devfrom
Open
refactor: remove unused DynamicDescription hack in tool.ts#25907srivenkateswaran6002 wants to merge 2 commits intoanomalyco:devfrom
srivenkateswaran6002 wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Issue : #25906
Closes # (Addressing technical debt identified in tool.ts)
Type of change
What does this PR do?
This PR removes the
DynamicDescriptiontype definition and the associated "hack" comment inpackages/opencode/src/tool/tool.ts.The type was marked with a// TODO: remove this hackcomment. My investigation of the codebase confirmed that this type is currently unused.Removing it reduces technical debt and simplifies the core tool interfaces.How did you verify your code works?
DynamicDescriptionand confirmed zero usages in any package or configuration.bun run typecheck --filter=opencodewhich passed successfully, ensuring no implicit dependencies or type-level issues were introduced by the removal.Screenshots / recordings
N/A (Refactor only, no UI changes)
Checklist
Note: I accidentally closed the linked issue (#25906) and don't have permissions to reopen it, but this PR contains the fix.