fix: find GitHub remote from any remote, not just origin#25955
fix: find GitHub remote from any remote, not just origin#25955Waridley wants to merge 1 commit intoanomalyco:devfrom
Conversation
Instead of checking only `origin`, this fix searches all remotes for one that successfully parses as a Github URL.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, there is one potentially related PR: PR #9323: fix(cli): support SSH aliases when installing opencode GitHub app Why it's related: This PR also addresses issues with the GitHub install command's handling of remote URLs. While #9323 focuses on SSH alias support, both PRs deal with parsing and handling GitHub remote URLs during the installation process. The current PR (25955) expands the remote detection to check all remotes rather than just "origin", which complements fixing SSH alias handling in remote URL parsing. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Issue for this PR
Closes #25956
Type of change
What does this PR do?
This PR fixes an issue where the GitHub install command only looked at the "origin" remote to find the repository. Now it parses all remotes and finds the first valid GitHub remote URL.
How did you verify your code works?
Installed locally and ran
opencode github installin a repo with nooriginremote.Screenshots / recordings
N/A
Checklist