Use antsibull-docs-parser to render semantic markup#88
Open
felixfontein wants to merge 1 commit intoansible-network:masterfrom
Open
Use antsibull-docs-parser to render semantic markup#88felixfontein wants to merge 1 commit intoansible-network:masterfrom
felixfontein wants to merge 1 commit intoansible-network:masterfrom
Conversation
Author
|
This is now ready for review! |
Author
|
Ping @Qalthos @NilashishC @goneri - not sure who is the correct person to bug, so I thought I'll ping you all since you all were working on this repo in the past :) |
goneri
approved these changes
May 22, 2023
Contributor
|
I can't say anything about the code because I'm not really into it... but this sounds like a good idea. I think this would make it easier to implement semantic markup for collections using Any chance to get this merged now that @goneri approved? |
Contributor
|
Any news on this? |
Author
|
@Qalthos @NilashishC ping |
f0cfeab to
89bf21a
Compare
89bf21a to
40463f4
Compare
Author
|
The remaining CI failures seem to be unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the Python library antsibull-docs-parser (https://github.com/ansible-community/antsibull-docs-parser) to render Ansible markup, including the new semantic markup.
The plain RST created by antsibull-docs-parser is slightly different from the one created by the original code:
This are the docs generated from the community.dns collection.
(I marked this as a draft since I want to wait a bit until antsibull-docs-parser reaches 1.0.0 before making this ready.)