fix: tighten permission_suggestions type from list[Any] to list[dict[str, Any]]#997
Open
2023Anita wants to merge 1 commit into
Open
fix: tighten permission_suggestions type from list[Any] to list[dict[str, Any]]#9972023Anita wants to merge 1 commit into
2023Anita wants to merge 1 commit into
Conversation
…str, Any]] The wire protocol delivers raw JSON objects (plain dicts) for each permission suggestion. list[Any] suppressed all type-checking on consumers of this field. list[dict[str, Any]] accurately reflects the wire format and restores type-checker coverage. Closes anthropics#957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
PermissionRequestHookInput.permission_suggestionstype annotation fromlist[Any]tolist[dict[str, Any]].Root Cause
The wire protocol delivers raw JSON objects (plain dicts) for each permission suggestion, but the field was typed as
list[Any], suppressing all type-checking on consumers. TheAnyannotation was a placeholder that was never tightened.Verification
python -m ruff check src/python -m mypy src/claude_agent_sdk/types.pyRisk / Compatibility
Zero risk. This is a strict narrowing of the type annotation —
dict[str, Any]is a subtype ofAny, so all existing code remains compatible. Type checkers will gain coverage; no runtime behavior changes.Related
Closes #957