Fix nextflow pipeline config lookup#277
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187.
load_pipeline_config()was walking one directory too far up fromscripts/utils/validators.py, so it looked for pipeline YAML files undernextflow-development/config/pipelinesinstead ofnextflow-development/scripts/config/pipelines. This updates the lookup to the actual scripts config directory so known pipelines such asrnaseqload correctly.Changes
scripts/config/pipelines.Testing
PYTHONDONTWRITEBYTECODE=1 /tmp/kwork-venv/bin/python -m unittest discover -s bio-research/skills/nextflow-development/scripts/testsI also ran the same regression assertion against an unmodified checkout before the fix and confirmed it failed because
load_pipeline_config("rnaseq")returnedNone.Note: I used Codex while preparing this change, reviewed the final diff, and ran the listed checks locally.