sm: launcher: rename update instances to run instances#535
Open
mlohvynenko wants to merge 1 commit intoaosedge:feature_release_9.1from
Open
sm: launcher: rename update instances to run instances#535mlohvynenko wants to merge 1 commit intoaosedge:feature_release_9.1from
mlohvynenko wants to merge 1 commit intoaosedge:feature_release_9.1from
Conversation
mlohvynenko
force-pushed
the
feature_sm_itf
branch
from
1baadee to
98c3fc6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_release_9.1 #535 +/- ##
=======================================================
- Coverage 85.21% 85.21% -0.01%
=======================================================
Files 313 313
Lines 28182 28211 +29
Branches 3773 3780 +7
=======================================================
+ Hits 24015 24039 +24
- Misses 4167 4172 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Service Manager launcher API from “update instances (stop/start lists)” to “run instances (desired set)”, moving stop/start decision-making and start ordering (by priority) into the launcher implementation.
Changes:
- Renamed launcher interface method from
UpdateInstances(...)toRunInstances(instances). - Updated SM launcher implementation to derive stop/start sets internally and to sort desired instances by priority before starting.
- Refactored and renamed SM launcher tests/mocks to match the new API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/core/sm/tests/mocks/launchermock.hpp |
Updates mock interface to RunInstances(...). |
src/core/sm/launcher/tests/launcher.cpp |
Renames tests and switches calls from UpdateInstances to RunInstances. |
src/core/sm/launcher/launcher.hpp |
Updates public API + internal helpers/state to support “desired set” flow. |
src/core/sm/launcher/launcher.cpp |
Implements RunInstances, adds sorting and internal stop-list derivation. |
src/core/sm/launcher/itf/launcher.hpp |
Updates launcher interface contract to RunInstances(...). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mlohvynenko
force-pushed
the
feature_sm_itf
branch
from
7d85bdf to
9f445ca
Compare
al1img
force-pushed
the
feature_release_9.1
branch
from
79d1152 to
febcb95
Compare
This patch updated launcher interface to handle run instances instead of update instances: - a list of desired run instances is passed to the launcher instead stop and start instances lists; - the launcher is responsible for stopping and starting instances based on the provided list of desired run instances; - instances are started based on the desired run instances priorities. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
mlohvynenko
force-pushed
the
feature_sm_itf
branch
from
9f445ca to
a45d5aa
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updated launcher interface to handle
run instances instead of update instances: