cm: launcher: change UpdateInstances to RunInstances by mykola-kobets-epam · Pull Request #540 · aosedge/aos_core_lib_cpp

mykola-kobets-epam · 2026-03-30T11:27:57Z

No description provided.

al1img · 2026-03-31T08:45:06Z

src/core/cm/launcher/itf/instancerunner.hpp

@@ -29,13 +29,10 @@ class InstanceRunnerItf {
     * Updates instances on specified node.


Run instance on specified node.

al1img · 2026-03-31T08:45:37Z

src/core/cm/launcher/node.cpp

-    for (const auto& instance : *stopInstances) {
-        LOG_INF() << "Update node stop instance" << Log::Field("instance", static_cast<const InstanceIdent&>(instance))
+    for (const auto& instance : *instancesToRun) {
+        LOG_INF() << "Update node run instance" << Log::Field("instance", static_cast<const InstanceIdent&>(instance))


"Run node instances"

al1img · 2026-03-31T08:46:00Z

src/core/cm/launcher/node.cpp

+        return {true, ErrorEnum::eNone};
+    }
+
+    // Check desired ⊆ running.


What does ⊆ mean?

that's from initial implementation
(set1 <= set2) and (set2 <= set1) => set1 == set2

removed the comments, not needed

al1img · 2026-03-31T08:46:22Z

src/core/cm/launcher/node.cpp

-    for (const auto& instance : *stopInstances) {
-        LOG_INF() << "Update node stop instance" << Log::Field("instance", static_cast<const InstanceIdent&>(instance))
+    for (const auto& instance : *instancesToRun) {
+        LOG_INF() << "Update node run instance" << Log::Field("instance", static_cast<const InstanceIdent&>(instance))


"Run node instances"

MykolaSuperman

Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

codecov · 2026-03-31T23:03:06Z

Codecov Report

❌ Patch coverage is 97.80220% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.21%. Comparing base (61e5def) to head (eada1a0).
⚠️ Report is 1 commits behind head on feature_release_9.1.

Files with missing lines	Patch %	Lines
src/core/cm/launcher/node.cpp	94.44%	2 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           feature_release_9.1     #540      +/-   ##
=======================================================
- Coverage                85.25%   85.21%   -0.04%     
=======================================================
  Files                      313      313              
  Lines                    28209    28182      -27     
  Branches                  3775     3773       -2     
=======================================================
- Hits                     24049    24016      -33     
- Misses                    4160     4166       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mlohvynenko

Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

al1img

Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

sonarqubecloud · 2026-04-01T10:50:34Z

Quality Gate failed

Failed conditions
61.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

mykola-kobets-epam force-pushed the cm-proto-change-adaptation branch from 8489da2 to 1b78de8 Compare March 30, 2026 14:23

al1img reviewed Mar 31, 2026

View reviewed changes

MykolaSuperman approved these changes Mar 31, 2026

View reviewed changes

mykola-kobets-epam force-pushed the cm-proto-change-adaptation branch 2 times, most recently from bf0e06f to a609cd7 Compare March 31, 2026 22:48

mlohvynenko approved these changes Apr 1, 2026

View reviewed changes

al1img approved these changes Apr 1, 2026

View reviewed changes

cm: launcher: change UpdateInstances to RunInstances

eada1a0

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

mykola-kobets-epam force-pushed the cm-proto-change-adaptation branch from a609cd7 to eada1a0 Compare April 1, 2026 10:32

al1img merged commit b572146 into aosedge:feature_release_9.1 Apr 1, 2026
6 of 7 checks passed

		@@ -29,13 +29,10 @@ class InstanceRunnerItf {
		* Updates instances on specified node.

Conversation

mykola-kobets-epam commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MykolaSuperman left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mlohvynenko left a comment

Choose a reason for hiding this comment

Uh oh!

al1img left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 31, 2026 •

edited

Loading