Replace resolvers with agnostic URL support #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…derFactory Added HdfsUrlStreamHandlerFactory and set it as the URL StreamHandlerFactory in a static initializer in LocalCachingContextClassLoaderFactory to handle the hdfs protocol. Closes apache#47
* Register a provider for the hdfs: URL stream handling, rather than override the system factory * Also fix SpotBugs and rename classes to match the naming convention from the classes they override (e.g. "URLStreamHandler" instead of "UrlStreamHandler")
* Remove resolvers (keep test coverage for file, http, and hdfs URL types) * Use url.openStream() * Be agnostic to different URL types * Depend on an HdfsURLStreamHandlerProvider for hdfs URL support * Place hdfs provider in its own module/jar * Clean up related POM and README stuff This fixes apache#47 This supersedes apache#48 and apache#49 alternate fixes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types)
This fixes #47
This supersedes #48 and #49 alternate fixes
(This builds on the work in #48, but was sufficiently different that I think it warranted a new PR)