Skip to content

agtype: fix substring() backend crash when start-offset is SQL NULL and length is supplied #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MuhammadTahaNaveed merged 1 commit into from
Apr 20, 2026
+9 −2
Merged

agtype: fix substring() backend crash when start-offset is SQL NULL and length is supplied #2401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/backend/utils/adt/agtype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8639,8 +8639,15 @@ Datum age_substring(PG_FUNCTION_ARGS)
PG_RETURN_NULL();
}

/* neither offset or length can be null if there is a valid string */
if ((nargs == 2 && nulls[1]) ||
/*
* neither offset nor length may be null when there is a valid string.
* Both arg positions must be checked whenever they are supplied; the
* previous condition missed the `start is null, length is provided`
* case (nargs == 3 && nulls[1]), which fell through to the numeric
* parser below and dereferenced an undefined Datum - crashing the
* backend (#2386).
*/
if ((nargs >= 2 && nulls[1]) ||
(nargs == 3 && nulls[2]))
{
ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
Expand Down
Loading