Skip to content

Conversation

@alien11689
Copy link
Contributor

No description provided.

@jbonofre jbonofre self-requested a review February 1, 2025 13:09
@jbonofre
Copy link
Member

jbonofre commented Feb 1, 2025

As I plan a new proxy and blueprint releases with JDK 17/21 support, let me quickly review/test this change.

@@ -1,203 +0,0 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, any artifact we distribute should have a clean LICENSE and NOTICE. I agree to remove for now, I will do a complete pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed on mailing list that there is plugin in parent pom that add these file during build, please check #410

<org.apache.aries.blueprint.sample.version>1.0.0</org.apache.aries.blueprint.sample.version>
<org.apache.aries.blueprint.version>1.0.0</org.apache.aries.blueprint.version>
<org.apache.aries.proxy.version>1.0.1</org.apache.aries.proxy.version>
<org.apache.aries.proxy.version>1.1.14</org.apache.aries.proxy.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this proxy release fully supports JDK 17+.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not
there is a problem with sun classes even in java 11+
You can take a look at #414

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web does not use proxy at all so I removed the dependency together with unused blueprint dependencies

<org.eclipse.osgi.version>3.11.3</org.eclipse.osgi.version>
<slf4j-api.version>1.7.7</slf4j-api.version>
<org.apache.felix.configadmin.version>1.9.26</org.apache.felix.configadmin.version>
<org.eclipse.osgi.version>3.16.0</org.eclipse.osgi.version>
Copy link
Contributor Author

@alien11689 alien11689 Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried setting the newest version 3.22.0 as it is in quiesce-manager-itest, but the container is not starting with error:

Security class "org.osgi.service.log.LogLevel"'s signer information does not match signer information of other classes in the same package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When order of dependencies is changed then this error dissappears but the highest eclipse version to use now is 3.17.0
Higher versions has WABs generated with missing headers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cause in the new versions of eclipse seems to be that url is:

webbundle:file:/tmp/test7207230737428988734.war?Bundle-SymbolicName=test.war.bundle&Web-ContextPath=foo

and new eclipse ignores generated input stream because sourceUrl has protocol file in https://github.com/eclipse-equinox/equinox/blob/e35221a86afd24ee21b7b9d02db298a90ace1bc0/bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/storage/Storage.java#L1158-L1181

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is in a separate PR #415
@jbonofre could you take a look?

@alien11689 alien11689 force-pushed the ARIES-2165-build-web-with-java-11-17-21 branch from fc00275 to c0090cf Compare February 7, 2025 21:07
@alien11689 alien11689 merged commit e702eb8 into trunk Feb 14, 2025
5 checks passed
@alien11689 alien11689 deleted the ARIES-2165-build-web-with-java-11-17-21 branch February 14, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants