feat(arrow/array): add Resize method to RecordBuilder#805
Open
oakad wants to merge 1 commit intoapache:mainfrom
Open
feat(arrow/array): add Resize method to RecordBuilder#805oakad wants to merge 1 commit intoapache:mainfrom
oakad wants to merge 1 commit intoapache:mainfrom
Conversation
Presently added Resize method addresses two, relatively common needs: 1. All fields within the Builder may need to be resized to the same length. 2. As part of error recovery process, fields may need to be truncated to the length of the shortest one, effectively discarding incomplete "rows". Fixes apache#796
zeroshade
requested changes
May 8, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Generally looks fine, but needs unit tests and to reference the relevant issue in the description.
zeroshade
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently added Resize method addresses two,
relatively common needs:
Fixes #796
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?