ARTEMIS-5819 remove HTTP idle connection stuff #6149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm removing all the HTTP-specific idle connection functionality for 2 reasons: - the client-side keep-alive mechanism is completely broken - this duplicates the pinging functionality already in the Core protocol When the client-side sends an HTTP request for keep-alive purposes, it sends a GET. The broker only handles POST requests and therefore throws a ClassCastException causing the connection to fail. This appears to have been broken for a long time. Furthermore, both the client-side and broker-side HTTP-specific keep-alive code appears to be completely unnecessary. When httpEnabled=true the Core client simply tunnels it's normal packets through HTTP requests, including the normal ping packets to & from the broker. There is no need to have another keep-alive mechanism assuming the client configures their clientFailureCheckPeriod and connectionTTL appropriately. I can only assume this code was added for a defunct use-case.
Contributor
Author
|
The full test-suite looks good on this. |
Contributor
|
This seems reasonable in terms of what was changed, can't speak to why it was there in the first place if protocol keep alive packets could cross without issue. |
Contributor
Author
|
@clebertsuconic, @andytaylor this code has been in place since before the donation. Either of you have any idea why it was there? It seems completely superfluous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm removing all the HTTP-specific idle connection functionality for 2 reasons:
When the client-side sends an HTTP request for keep-alive purposes, it sends a GET. The broker only handles POST requests and therefore throws a ClassCastException causing the connection to fail. This appears to have been broken for a long time.
Furthermore, both the client-side and broker-side HTTP-specific keep-alive code appears to be completely unnecessary. When httpEnabled=true the Core client simply tunnels it's normal packets through HTTP requests, including the normal ping packets to & from the broker. There is no need to have another keep-alive mechanism assuming the client configures their clientFailureCheckPeriod and connectionTTL appropriately. I can only assume this code was added for a defunct use-case.