Skip to content

Conversation

@zymap
Copy link
Member

@zymap zymap commented Jan 12, 2026

Descriptions of the changes in this PR:

Fix #xyz

Main Issue: #xyz

BP: #xyz

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good jobs

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Netty library from version 4.1.121.Final to 4.1.130.Final, along with the associated netty-tcnative library from 2.0.70.Final to 2.0.74.Final.

Changes:

  • Updated Netty version property in pom.xml from 4.1.121.Final to 4.1.130.Final
  • Updated all NOTICE and LICENSE distribution files to reflect the new Netty and tcnative versions

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pom.xml Updated netty.version property to 4.1.130.Final
bookkeeper-dist/src/main/resources/NOTICE-server.bin.txt Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74
bookkeeper-dist/src/main/resources/NOTICE-bkctl.bin.txt Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74
bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74
bookkeeper-dist/src/main/resources/LICENSE-server.bin.txt Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74
bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74
bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zymap zymap changed the title Upgrade netty to 4.1.140 Final Upgrade netty to 4.1.130 Final Jan 12, 2026
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenLuMT StevenLuMT merged commit 9ce7cc9 into apache:master Jan 12, 2026
46 of 48 checks passed
@zymap zymap deleted the yong/upgrade-netty-version branch January 13, 2026 01:32
zymap added a commit that referenced this pull request Jan 13, 2026
Upgrade netty to 4.1.130 Final (#4699)

(cherry picked from commit 9ce7cc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants