-
Notifications
You must be signed in to change notification settings - Fork 962
Upgrade netty to 4.1.130 Final #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
StevenLuMT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the Netty library from version 4.1.121.Final to 4.1.130.Final, along with the associated netty-tcnative library from 2.0.70.Final to 2.0.74.Final.
Changes:
- Updated Netty version property in pom.xml from 4.1.121.Final to 4.1.130.Final
- Updated all NOTICE and LICENSE distribution files to reflect the new Netty and tcnative versions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated netty.version property to 4.1.130.Final |
| bookkeeper-dist/src/main/resources/NOTICE-server.bin.txt | Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
| bookkeeper-dist/src/main/resources/NOTICE-bkctl.bin.txt | Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
| bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt | Updated Netty library references from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
| bookkeeper-dist/src/main/resources/LICENSE-server.bin.txt | Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
| bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt | Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
| bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt | Updated Netty library references and source URLs from 4.1.121 to 4.1.130 and tcnative from 2.0.70 to 2.0.74 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Descriptions of the changes in this PR:
Fix #xyz
Main Issue: #xyz
BP: #xyz
Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
Changes
(Describe: what changes you have made)