Skip to content

[CALCITE-4121] Driver misplaces properties from URL while connecting (Laksh Singla) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LakshSingla wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

[CALCITE-4121] Driver misplaces properties from URL while connecting (Laksh Singla) #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/java/org/apache/calcite/avatica/remote/Driver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import org.apache.calcite.avatica.AvaticaConnection;
import org.apache.calcite.avatica.BuiltInConnectionProperty;
import org.apache.calcite.avatica.ConnectStringParser;
import org.apache.calcite.avatica.ConnectionConfig;
import org.apache.calcite.avatica.ConnectionProperty;
import org.apache.calcite.avatica.DriverVersion;
Expand Down Expand Up @@ -173,9 +174,13 @@ AvaticaHttpClient getHttpClient(AvaticaConnection connection, ConnectionConfig c
// super.connect(...) should be creating a service and setting it in the AvaticaConnection
assert null != service;

// extract the parameters passed in the URL info
final String urlSuffix = url.substring(getConnectStringPrefix().length());
final Properties info2 = ConnectStringParser.parse(urlSuffix, info);

service.apply(
new Service.OpenConnectionRequest(conn.id,
Service.OpenConnectionRequest.serializeProperties(info)));
Service.OpenConnectionRequest.serializeProperties(info2)));

return conn;
}
Expand Down