Ref #596: adapt library 'camel-test-blueprint-junit5' to camel-karaf#651
Ref #596: adapt library 'camel-test-blueprint-junit5' to camel-karaf#651essobedo merged 7 commits intoapache:mainfrom
Conversation
jhattab
force-pushed
the
596
branch
2 times, most recently
from
a1238cc to
4dac01b
Compare
essobedo
changed the title
essobedo
left a comment
essobedo
left a comment
There was a problem hiding this comment.
Thx for the PR, please avoid huge PR like this one next time as it too long to review. Regarding the PR, could you please remove all tests that seem to test Camel instead of camel-blueprint?
…nt-junit5 from version 3.22.0-SNAPSHOT
|
Thank you very much for the code review. I have reworked the PR by splitting it into two commits: one containing the code inherited from the Karaf Camel 3.22.0 version, and a second one with the adaptations for version 4.10.8-SNAPSHOT. I hope this makes the changes easier to review. Regarding the tests, I believe they are necessary to ensure that the Camel patterns are correctly ported and behave as expected in a Blueprint context, even if they may appear to test Camel itself. |
|
camel-blueprint-main and camel-test-blueprint-junit5 are not bundles or components; perhaps we should consider moving these dependencies to another directory in the project, for example under tests? |
I agree, if they are not compoments, please move them under tests indeed 👍 |
|
Why did you remove the content of several classes into camel-integration-test? |
…nt-main' to tests subdirectory
Sorry about that — it wasn’t intentional and I missed it. (Probably automatic refactoring.) |
…-INF/services/org/apache/camel/other.properties
…rvices/org/apache/camel/other.properties
|
Thank you for the contribution |
2 participants
fixes #596
Here’s my first Pull Request on GitHub.
I’m open to any feedback that could help improve the code and the way we collaborate on these projects.
All the unit tests should normally be working.
I reintroduced the code and unit tests that were present in version 3.22.4 of camel-karaf, and then took inspiration from the changes made to the Spring tests in the Apache Camel project.