Skip to content

Revert "chore(ci): Fix parent POM dependency change detection (#22022)"#22279

Merged
gnodet merged 1 commit intomainfrom
revert-detect-dependencies-22022
Mar 26, 2026
Merged

Revert "chore(ci): Fix parent POM dependency change detection (#22022)"#22279
gnodet merged 1 commit intomainfrom
revert-detect-dependencies-22022

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Mar 26, 2026

Summary

Reverts the detect-dependencies CI action back to its original implementation (#22022). The reworked version is causing issues in CI. A proper fix will be done in #22247.

Known limitation

The original detect-test.sh searches for ${property-name} references in module pom.xml files to find affected modules. This works for ~78% of the version properties in parent/pom.xml (395 out of 504), which directly reference the property in their pom. However, ~22% of properties are only used through <dependencyManagement> inheritance and are not detected by this grep-based approach (e.g., caffeine-version, bytebuddy-version). This limitation will be addressed in #22247.

Test plan

  • CI passes

This reverts the detect-dependencies CI action back to its original
implementation. The reworked version is causing issues in CI.
A proper fix will be done in #22247.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet requested review from apupier and squakez March 26, 2026 10:49
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is reverting the situation exactly to the same working version, then it's fine. However, I suggest to perform a test on a private fork before, to make sure that, indeed, given a change on a parent pom dependency, triggers the test on the affected modules.

Copy link
Contributor

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same than @squakez

given recent experience, I think these kid of changes needs to be tested first

@gnodet
Copy link
Contributor Author

gnodet commented Mar 26, 2026

Tested on the gnodet fork with a dnsjava-version bump (3.6.4 → 3.6.3). The detect-dependencies step correctly detected the change, found camel-dns as an affected module, and ran its tests successfully (22 tests, 0 failures).

Full CI run: https://github.com/gnodet/camel/actions/runs/23599119328

Claude Code on behalf of Guillaume Nodet

@gnodet gnodet merged commit 255463d into main Mar 26, 2026
2 checks passed
@gnodet gnodet deleted the revert-detect-dependencies-22022 branch March 26, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants