CASSANDRA-20926 mutation tracking config #4395
Conversation
maedhroz
changed the title
| if (SchemaConstants.isSystemKeyspace(keyspaceName)) | ||
| throw ire("Mutation tracking is not supported on system keyspaces"); | ||
|
|
||
| if (!DatabaseDescriptor.getMutationTrackingEnabled()) |
There was a problem hiding this comment.
We'll need to move this, and probably some of the other pre-existing validation, out of apply and into validate.
DDL statements are encoded as entries in the metadata log and once committed must be able to be applied by all nodes, so divergent config across instances would create an issue here.
Also, log entries may be replayed after a bounce and changes to config could interfere with that & prevent the node from coming back up (c.f. CASSANDRA-20452)
There was a problem hiding this comment.
@beobal Thanks for the note. I'm going to pick this up soon...
| if (SchemaConstants.isSystemKeyspace(keyspaceName)) | ||
| throw ire("Mutation tracking is not supported on system keyspaces"); | ||
|
|
||
| if (!DatabaseDescriptor.getMutationTrackingEnabled()) |
There was a problem hiding this comment.
Same point as on AlterKeyspaceStatement applies here
|
Closed in favor of #4559, but the open comments in this PR still need to be addressed... |
4 participants
No description provided.