[CASSANDRA-21089][trunk] Change default for cassandra.set_sep_thread_name to false + invoke Thread.setName only if an phase changed#4539
Conversation
| SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"), | ||
| SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"), | ||
| SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"), | ||
| SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"), |
There was a problem hiding this comment.
Can we make this a hot-prop so it can be toggled via JMX?
There was a problem hiding this comment.
I think, yes, it would cost 1 volatile read but I suppose it is an acceptable cost for this place
There was a problem hiding this comment.
I don't see a lot of value allowing this to be changed via JMX. @aratno what is the idea here? Do you see use cases where we might need to toggle this during runtime
There was a problem hiding this comment.
originally I thought that it would be easy to do, but then I have realised that there is no suitable existing JMX bean for it and I'll have to introduce a new one, so it becomes more expensive (add bean, publication for it, unregistering, API to retrieve the value), so this is why actually the change is still non-merged :-).
If we do not have a real case I would suggest to keep the current change simple, with ability to change the parameter via restart, and add the runtime change feature later in case of a real demand.
| SEED_COUNT_WARN_THRESHOLD("cassandra.seed_count_warn_threshold"), | ||
| SERIALIZATION_EMPTY_TYPE_NONEMPTY_BEHAVIOR("cassandra.serialization.emptytype.nonempty_behavior"), | ||
| SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "true"), | ||
| SET_SEP_THREAD_NAME("cassandra.set_sep_thread_name", "false"), |
There was a problem hiding this comment.
I don't see a lot of value allowing this to be changed via JMX. @aratno what is the idea here? Do you see use cases where we might need to toggle this during runtime
netudima
force-pushed
the
sep_thread_name-trunk
branch
from
815ae8e to
ca7568e
Compare
…PU usage Add an extra optimization if it is enabled: invoke Thread.setName only if an phase changed patch by Dmitry Konstantinov; reviewed by Francisco Guerrero, Jyothsna Konisa for CASSANDRA-21089
netudima
force-pushed
the
sep_thread_name-trunk
branch
from
ca7568e to
baf8857
Compare
|
Closed via 32162cf |
4 participants
No description provided.